Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 fix: Prevent Empty File Uploads & Assistants Fixes #2611

Merged
merged 4 commits into from
May 3, 2024
Merged

馃悰 fix: Prevent Empty File Uploads & Assistants Fixes #2611

merged 4 commits into from
May 3, 2024

Conversation

danny-avila
Copy link
Owner

Summary

  • prevent users from uploading empty files
  • modified the default models with new OpenAI models
  • ensured that the assistant_id is appropriately defined when necessary.
  • enabled the fetching of models for assistants

Closes #2605

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit c8bacea into main May 3, 2024
3 checks passed
@danny-avila danny-avila deleted the minor-fixes-v1 branch May 3, 2024 16:49
jinzishuai pushed a commit to aitok-ai/LibreChat that referenced this pull request May 20, 2024
@danny-avila
馃悰 fix: Prevent Empty File Uploads & Assistants Fixes (danny-avila#2611)
d3fdbb1 
* chore: update default models for openai/assistants

* fix: allows assistants models fetching

* change default models order, ensure assistant_id is defined if intended

* fix: prevent empty files from being uploaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Attach empty file causes an error after sending a message
1 participant
@danny-avila