testRegisterEncoding

src/EncodingFactory.php

@@ -90,7 +90,7 @@ public static function registerEncoding(string $encodingName, Closure $construct
         static::initConstructor();
 
         if (array_key_exists($encodingName, self::$encodingConstructors)) {
-            throw new Exception("{$encodingName} already exists");
+            throw new InvalidArgumentException("\"{$encodingName}\" already exists");
         }
 
         self::$encodingConstructors[$encodingName] = $constructor;

tests/EncodingFactoryTest.php

@@ -2,6 +2,7 @@
 
 namespace Danny50610\BpeTokeniser\Tests;
 
+use Danny50610\BpeTokeniser\Encoding;
 use Danny50610\BpeTokeniser\EncodingFactory;
 use InvalidArgumentException;
 use PHPUnit\Framework\TestCase;
@@ -44,4 +45,26 @@ public function testCreateByModelNameWithNonExist()
 
         EncodingFactory::createByModelName('danny');
     }
+
+    public function testRegisterEncoding()
+    {
+        EncodingFactory::registerEncoding('danny', function () {
+            $banks = [];
+            return new Encoding('danny', $banks, '', []);
+        });
+
+        $enc = EncodingFactory::createByEncodingName('danny');
+        $this->assertSame('danny', $enc->getName());
+    }
+
+    public function testRegisterEncodingAlreadyExists()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('"cl100k_base" already exists');
+
+        EncodingFactory::registerEncoding('cl100k_base', function () {
+            $banks = [];
+            return new Encoding('cl100k_base', $banks, '', []);
+        });
+    }
 }