Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use light states #56

Draft
wants to merge 7 commits into
base: 1.16
Choose a base branch
from
Draft

use light states #56

wants to merge 7 commits into from

Conversation

lublak
Copy link
Contributor

@lublak lublak commented May 2, 2021

No description provided.

@lublak lublak mentioned this pull request May 2, 2021
Closed
@lublak
Copy link
Contributor Author

lublak commented May 2, 2021

Here is the current problem. The light is updated correctly. But there is often a flicker. Also visible with f3.

change the new light level to 3 from 0:
Server: 0, 3, 0, 3
Client: 0, 3, 0, 3

I think the problem is with the sync?

@dannydjdk dannydjdk linked an issue May 3, 2021 that may be closed by this pull request
[bug] optifine lightning #13
Open
@lublak
Copy link
Contributor Author

lublak commented May 3, 2021 •
edited
Loading

I add a tiny redstone block to a tiny redstone lamp:

[03Mai2021 13:17:25.876] [Render thread/INFO] [com.dannyandson.tinyredstone.TinyRedstone/]: light update (remote)
[03Mai2021 13:17:25.876] [Render thread/INFO] [com.dannyandson.tinyredstone.TinyRedstone/]: sync (remote)
[03Mai2021 13:17:25.877] [Server thread/INFO] [com.dannyandson.tinyredstone.TinyRedstone/]: light update
[03Mai2021 13:17:25.877] [Server thread/INFO] [com.dannyandson.tinyredstone.TinyRedstone/]: sync
[03Mai2021 13:17:25.879] [Server thread/INFO] [com.dannyandson.tinyredstone.TinyRedstone/]: light update
[03Mai2021 13:17:25.978] [Render thread/INFO] [com.dannyandson.tinyredstone.TinyRedstone/]: sync (remote)
[03Mai2021 13:17:26.027] [Render thread/INFO] [com.dannyandson.tinyredstone.TinyRedstone/]: sync (remote)

@lublak
Copy link
Contributor Author

lublak commented May 5, 2021 •
edited
Loading

so now are the glitches fixed: next bugs

  • short flash of light when the panel is empty on joining and then cells are placed on it
  • short flash of light wenn remove cells?
  • NullPointerException Failed to load probably the problem "flash of light" is caused by this.
  • server light and client light out of sync
    grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] optifine lightning
1 participant
@lublak