Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cursor: pointer from default #13

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Conversation

danoc
Copy link
Owner

@danoc danoc commented Dec 14, 2018

Removing this because the button element doesn't include it by default.

It is also easy to add globally with:

[role="button"] {
  cursor: pointer;
}

Fixes #5.

Removing this because the button element doesn't include it by default.

It is also easy to add globally with:

```css
[role="button"] {
  cursor: pointer;
}
```
@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          24     23    -1     
  Branches        9      8    -1     
=====================================
- Hits           24     23    -1
Impacted Files Coverage Δ
src/index.jsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a743d1...97009f5. Read the comment docs.

@danoc danoc merged commit 3be2cb8 into master Dec 14, 2018
@danoc danoc deleted the daniel/remove-cursor-pointer branch December 14, 2018 04:12
danoc added a commit that referenced this pull request Nov 26, 2019
Removing this because the button element doesn't include it by default.

It is also easy to add globally with:

```css
[role="button"] {
  cursor: pointer;
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant