Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to TypeScript #26

Closed
wants to merge 1 commit into from
Closed

Convert to TypeScript #26

wants to merge 1 commit into from

Conversation

danoc
Copy link
Owner

@danoc danoc commented Jun 16, 2019

Fixes #16.

⚠️ Never written Typescript before so this may be horribly wrong.

@danoc danoc mentioned this pull request Jun 16, 2019
Closed
@thisis-Shitanshu
Copy link
Contributor

Hey @danoc . If convenient to you, can I join in?
It's an cool project and I am looking for an opportunity to contribute. Also, I have worked on TypeScript.

@danoc
Copy link
Owner Author

danoc commented Jul 29, 2019

Hey, @thisis-Shitanshu! Thanks for reaching out. Are you able to review this PR? Not sure what kind of permissions GitHub provides.

@thisis-Shitanshu
Copy link
Contributor

np version 5.0.3 was not incompatible with "yarn" you need to use npm or an alternative to np.
PR #28
Solves the issue, you can use that. I have made a migration from yarn to npm.

@danoc
Copy link
Owner Author

danoc commented Nov 26, 2019

Closing this in favor of #28.

@danoc danoc closed this Nov 26, 2019
@danoc danoc deleted the daniel/typescript branch November 26, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write TypeScript definitions
2 participants
@danoc @thisis-Shitanshu