Multiple modifications for formatting and function #21
Conversation
Updated connect/disconnect functionality Removed some hard coded parameters Clarified parameter naming Spelling fixes Adjusted examples due to changes in code
Sync localDev with dev
Spelling changes slog modifications for errors
Use a struct for the list services response.
|
Thanks for all the updates. I've started reviewing it and like what I see so far. It would appear I'm having trouble with the reconnection and noreconnection tests. Might just be a timeout thing, I'll look at it further over the next few days as I get a chance. Also, I really need to start using a spell checker - I had so many typos. |
|
Haha all good. I get just focusing on the content as that is what is more important at the end of the day. |
|
I found the problem with the reconnect test. See this comment: #21 (comment) |
… message failure due to disconnect
Update test files to current version
Corrected Connect and Disconnect methods to prevent multiple goroutines from triggering the methods Modify sequence number on Connect to add some randomness to connection ID to allow multiple concurrent clients to one device
… connection limits already Handle all disconnect in send_recv_data
…e second read that should fail would succeed or fail. (Unknown success due to second read or the keep alive could discover the broken connection)
Update for working tests
|
@danomagnum Everything should now be up to date and ready for additional review. |
Here is a partial functional update for the code modifications that I am working on to better use the library for me. So far, all the functional code updates are for the client. You will see some modifications for the server, but they were nonfunctional spelling/grammar updates.
If you do/do not like the direction that this code is going, feel free to let me know and I can try to mesh our visions.
In case I did not make it clear in my issue, great job with the code already! This is just my attempt to add what I view as some polish.
Key updates include:
Testing:
All automated tests pass.
I have confirmed a large portion (hopefully all) of the functionality that I touched on an AB CompactLogix with no noticed issues.