Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed your issues #1

Closed
wants to merge 2 commits into from
Closed

Fixed your issues #1

wants to merge 2 commits into from

Conversation

mazbox
Copy link
Contributor

@mazbox mazbox commented Jan 21, 2011

Hey Dan

I've been working on an ofxPd for a while, but just haven't made it public. I fixed the issue of the file not being found (it's something to do with not including the right header files - I had to put #define HAVE_UNISTD_H or something in some of the Pd files.

I also added a few features which you'll see in the header...

/// send messages to pd
void sendFloat(string messageName, float value);
void sendBang(string messageName);
void sendMidiNote(int channel, int noteNum, int velocity);
void sendMidiControlChange(int channel, int ctlNum, int value);
void sendMidiBend(int channel, int value);
void sendMidiProgramChange(int channel, int program);
void sendMidiPolyTouch(int channel, int noteNum, int value);
void sendMidiAfterTouch(int channel, int value);

Also, I'm gonna send you my version of ofxPd, maybe we can give the methods better names - i.e. all of the methods start with pdXxxx. Do we need that?

In terms of the callbacks, maybe it would be better to have a separate listener class - i.e. you call addListener() on the ofxPd object, and provide a subclass of ofxPdListener.

What say you?

cheers

Marek

@danomatika
Copy link
Owner

Ok, I brought in and updated your changes:

  • added your sending functions
  • changed openPatch so it handles the path automatically
  • updated the xcode project so it works with the latest OF (007) on github (but breaks 0062)
  • HAVE_UNISTD_H is now defined in the project

the pdXXX prefixes stay for now until an listener/event system can be added.

@samubence samubence mentioned this pull request Sep 25, 2012
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants