Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Dan
I've been working on an ofxPd for a while, but just haven't made it public. I fixed the issue of the file not being found (it's something to do with not including the right header files - I had to put #define HAVE_UNISTD_H or something in some of the Pd files.
I also added a few features which you'll see in the header...
/// send messages to pd
void sendFloat(string messageName, float value);
void sendBang(string messageName);
void sendMidiNote(int channel, int noteNum, int velocity);
void sendMidiControlChange(int channel, int ctlNum, int value);
void sendMidiBend(int channel, int value);
void sendMidiProgramChange(int channel, int program);
void sendMidiPolyTouch(int channel, int noteNum, int value);
void sendMidiAfterTouch(int channel, int value);
Also, I'm gonna send you my version of ofxPd, maybe we can give the methods better names - i.e. all of the methods start with pdXxxx. Do we need that?
In terms of the callbacks, maybe it would be better to have a separate listener class - i.e. you call addListener() on the ofxPd object, and provide a subclass of ofxPdListener.
What say you?
cheers
Marek