Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket empty? #361

Closed
pmaji opened this issue Apr 14, 2019 · 7 comments
Closed

Websocket empty? #361

pmaji opened this issue Apr 14, 2019 · 7 comments

Comments

@pmaji
Copy link

pmaji commented Apr 14, 2019

Hey all,

We use your package (ever since GDAX) as part of this whale watching app. Recently, we noticed that the websockets were just coming back empty. Is this something you're aware of?

@noah222
Copy link

noah222 commented Apr 14, 2019

what feed are you using? I've been using the 'matches' feed and have had no lapse in data. Be aware that there was recently an issue with bitcoin and the bitcoin market was halted for a few hours. When this happens there are no trades and the feed is empty. I do resubscribe often because the feed drops out quite regularly, then you are sure to get the next trade when it happens.

@pmaji
Copy link
Author

pmaji commented Apr 14, 2019

I don't know exactly what 'matches' feed means in this case, but I think we're using the same data. We're only using cases where the message is matched. You can see the small snippet of code that I'm referring to here.

It is doing better today, so maybe it was partially the btc problem you mentioned, but it appears that I am needing to resubscribe far more often than I was a few months ago...

@noah222
Copy link

noah222 commented Apr 14, 2019

I use my own script for managing a connection to the feed data, and the subscription message is:

message = {
"type": "subscribe",
"channels": [{"name": "matches", "product_ids": ["ETH-USD"]}]
}

I resubscribe every minute or after several message time outs, just in case. It feels totally redundant but not missing data is worth it, especially when in the middle of trades. The only time I missed data in the last month was when my power went out :)

@pmaji
Copy link
Author

pmaji commented Apr 14, 2019

Appreciate your sharing that. Sharing with my co-contributor: @theimo1221

@mcardillo55
Copy link
Collaborator

Are you still seeing this @pmaji ?

@pmaji
Copy link
Author

pmaji commented Nov 22, 2020

@mcardillo55
Copy link
Collaborator

Are you trying to get the code in gdax_book.py to work? And which version of cbpro are you using?

I recommend using the version from git (trying to get it updated on PyPi, but you can pip install git+https://github.com/danpaquin/coinbasepro-python.git
for now)

WebsocketClient now requires channels. See 646e99b for the changes you'll need to make to get gdax_book.py working again. I'm not sure if this is directly the root of the issue, but seems like a good place to start.

@pmaji pmaji closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants