Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag List Suggestions? #48

Closed
klyxmaster opened this issue Jun 2, 2014 · 7 comments
Closed

Tag List Suggestions? #48

klyxmaster opened this issue Jun 2, 2014 · 7 comments
Labels

Comments

@klyxmaster
Copy link

Ya Ya,I am probably the only one with a massive tag list :-P
That said, anyone have a way to make this into a drop down menu style?
I can write it myself, just tell me what file I need to edit (too lazy to look right now) heheheh

@klyxmaster
Copy link
Author

Here we go 👍
system/functions.php
line 646

    ksort($tag_collection);

        echo '<h3>Game Genre</h3>';
        ?>
        <select onchange="this.options[this.selectedIndex].value && (window.location = this.options[this.selectedIndex].value);">
            <option value="">Select Genre...</option>
            <?php
                foreach ($tag_collection as $tag => $count)
                {
                    echo '<option value="'.site_url().'tag/'.$tag.'" style="font-size:14px;">'.$tag.'&nbsp;<span class="count">(' . $count . ')</span></option>';
                }
            ?>
        </select>
        <?php
        /*
        echo '<ul class="taglist">';
            foreach ($tag_collection as $tag => $count){
            echo '<li class="item"><a href="' . site_url() . 'tag/' . $tag . '">' . $tag . '</a> <span class="count">(' . $count . ')</span></li>';
        }
        echo '</ul>';
        */

@danpros
Copy link
Owner

danpros commented Jun 2, 2014

HTMLy is very easy to hack, eh? 😄

@klyxmaster
Copy link
Author

Hack? It's open source. No hacking required. Lol
On Jun 2, 2014 3:36 AM, "Danang Probo Sayekti" notifications@github.com
wrote:

HTMLy is very easy to hack, eh? [image: 😄]


Reply to this email directly or view it on GitHub
#48 (comment).

@ncang
Copy link

ncang commented Jun 3, 2014

hack = change something get better, 👍

@fahmi182
Copy link
Contributor

fahmi182 commented Jun 3, 2014

Wow , coool.. ! how about using http://harvesthq.github.io/chosen/ to make it some awesome :)

@klyxmaster
Copy link
Author

@ncang no silly, thats called "modding" (i.e. moding a game makes it better, hacking a game to cheat/pirate ) hehehe

@klyxmaster
Copy link
Author

@fahmi182 jquery is an overkill these days. I chose the simple drop down because I WANT users to see the many genres of games are available. The one you propose are for drop downs where users KNOW what they want - ergo their country selection. For example, some people may not know there are "Book" games, or "Ricochet" games, so they would not type it in.
With that said, the examples shown there, can be done with php/html without the heavy overhead of jquery.

@Kanti Kanti added the question label Dec 4, 2014
@Kanti Kanti closed this as completed Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants