Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency danger to v3.7.0 #130

Merged
merged 1 commit into from May 18, 2018
Merged

Update dependency danger to v3.7.0 #130

merged 1 commit into from May 18, 2018

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 16, 2018

This Pull Request updates dependency danger from v3.6.6 to v3.7.0

Note: This PR was created on a configured schedule ("on the first day of the month") and will not receive updates outside those times.

Release Notes

v3.7.0

Compare Source

  • Adds support for the GH Checks API.

    This brings some interesting architectural changes inside Danger, but more important to you dear reader, is that using
    the Checks API has some API restrictions. This makes in infeasible to re-use the user access token which we've
    previously been recommending for setup.

    Instead there are two options:

    The security model of the GitHub app means it's totally safe to use our GitHub app, it can only read/write to checks
    and has no access to code or organizational data. It's arguably safer than the previous issue-based comment.

    To use it, you need to hit the above link, install the app on the org of your choice and then get the install ID from
    the URL you're redirected to. Set that in your CI's ENV to be DANGER_JS_APP_INSTALL_ID and you're good to go.

    If you want to run your own GitHub App, you'll need to set up a few ENV vars instead:

    • DANGER_GITHUB_APP_ID - The app id, you can get this from your app's overview page at the bottom
    • DANGER_GITHUB_APP_PRIVATE_SIGNING_KEY - The whole of the private key as a string with \n instead of newlines
    • DANGER_GITHUB_APP_INSTALL_ID - The installation id after you've installed your app on an org

    Checks support is still a bit of a WIP, because it's a whole new type of thing. I don't forsee a need for Danger to be
    deprecating the issue based commenting (we use that same infra with bitbucket).

    So now there are three ways to set up communications with GitHub, I'm not looking forwards to documenting that.

    [@​orta][]

  • JSON diffs use the JSON5 parser, so can now ignore comments in JSON etc [@​orta][]

  • Allows the synchronous execution of multiple dangerfiles in one single "danger run".

    Not a particularly useful feature for Danger-JS, but it means Peril can combine many runs into a single execution
    unit. This means people only get 1 message. [@​orta][]



This PR has been generated by Renovate Bot.

@react-tether-bot
Copy link

Messages
📖

Hey @renovate[bot], thanks for submitting a pull request! 😸

📖

🤔 Hmmm, code coverage is looking low for the whole codebase.

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/react-tether.js (0/0) 100% (0/0) 100% (0/0) 100% (0/0) 100%
src/TetherComponent.jsx (67/80) 84% (67/80) 84% (17/24) 71% (35/46) 76%
Total (67/80) 84% (67/80) 84% (17/24) 71% (35/46) 76%

Generated by 🚫 dangerJS

@coveralls
Copy link

Pull Request Test Coverage Report for Build 222

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.952%

Totals Coverage Status
Change from base Build 221: 0.0%
Covered Lines: 67
Relevant Lines: 80

💛 - Coveralls

@renovate renovate bot merged commit 4a3a082 into master May 18, 2018
@renovate renovate bot deleted the renovate/danger-3.x branch May 18, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants