add UNSAFE to componentWillUpdate #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you may need to add 1.x to your travis ci settings |
|
I think a patch update should suffice. |
|
Thanks for the PR, trying to get to it some time this week, sorry for the wait! |
|
No problem man, I work at a big company, we move slowly 😄 |
|
Could we also get the re-render fix (#211) in this branch/patch? I can work on a |
|
Published in 1.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! At work we're trying to update to React 16.10, and we need to make sure all unsafe lifecycle methods have UNSAFE prefixed, so I just wanted to add this so that others who are still dependent on 1.x and can't upgrade yet, have the UNSAFE here.