Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RenderProp typing more generic #221

Merged

Conversation

leabaertschi
Copy link
Contributor

like this also e.g. SVGElements can be used as target or element of a
tether component

fixes #220

like this also e.g. SVGElements can be used as target or element of a
tether component
@react-tether-bot
Copy link

Messages
📖 🤔 Hmmm, code coverage is looking low for the whole codebase.
📖 Hey @leabaertschi, thanks for submitting a pull request! 😸

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/react-tether.js (0/0) 100% (0/0) 100% (0/0) 100% (0/0) 100%
src/TetherComponent.jsx (70/82) 85% (72/84) 86% (22/28) 79% (55/63) 87%
Total (70/82) 85% (72/84) 86% (22/28) 79% (55/63) 87%

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.207% when pulling f8c715b on leabaertschi:flexible-render-prop-typing into 0549e22 on danreeves:master.

@danreeves
Copy link
Owner

Awesome, thanks!

@danreeves danreeves changed the title make RenderProp typing more general Make RenderProp typing more generic Jan 13, 2020
@danreeves danreeves merged commit 4486ada into danreeves:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change RenderProp typing to be more flexible
4 participants