Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates dependency danger from
v3.3.2
tov3.5.1
Release Notes
v3.4.0
Adds support for inline comments when using GitHub.
This is one of those "massive under the hood" changes, that has a tiny user DSL surface. From this point onwards
fail
,warn
,message
andmarkdown
all take an extra two optional params:file?: string
andline?: number
.Adding
file
andline
to the call of any exported communication function will trigger one of two things:Inline messages are edited/created/deleted with each subsequent run of
danger ci
in the same way the main commentdoes. This is really useful for: linters, test runners and basically anything that relies on the contents of a file
itself.
If you're using
danger process
to communicate with an external process, you can return JSON like:-- [@sunshinejr][]
Adds a data validation step when Danger gets results back from a process . [@orta][]
v3.4.1
v3.4.2
v3.4.3
v3.4.4
[@sunshinejr][]
v3.4.5
v3.4.6
v3.4.7
v3.5.0
v3.5.1
Commits
v3.4.0
484671d
Adds changelog + some light docs73e49bd
Merge master674610b
Pass the danger ID alongb1ce78c
Test out the inline on danger62ad270
Update repo slug for GithubAPI to be a base instead of pr5fc6d66
Add logging for inline comments1499ed6
Remove the testing inline messagesdd7ed3b
Convert console.logs to debug8b72d0f
Remove some console logs0c7e7d7
Merge pull request #529 from sunshinejr/file_line_api02dd89c
Adds support for a validation step on the danger resutlsa31bdf0
Merge pull request #548 from danger/validate9965176
Prepare for a releasea49c379
Remove the isInline function from being classed as a part of the danger DSLv3.4.1
20872e7
Update CHANGELOG.md15fc57b
Prepare for danger 3.4.1v3.4.2
40ebf98
Merge branch 'master' of https://github.com/danger/danger-js672d573
Fix a problem with a big comment for the same file/linef5ecf31
Merge pull request #550 from danger/inline_mode_fix_1eef53c2
Releasev3.4.3
9ef1013
Fix a bug with multiple updates for the inline comment2e36e21
Add Changelog entry2418999
Merge pull request #551 from danger/inline_mode_fix_2069a617
Releasev3.4.4
697ef32
Fix a bug where Danger would get all inline comments450d42b
Add test cases for danger getting inline comments from apid70631a
Add Changelog entry13e4eb2
Merge pull request #553 from danger/inline_mode_fix_3cb2994f
3.4.4v3.4.5
2a4ca06
Don't print error for commit status when there was no error71aa70a
Merge pull request #555 from danger/sunshinejr-patch-1b4e86ff
3.4.5v3.4.6
8265595
Remove deprecated babel 7 sourceMapTarget89ffbb2
Update CHANGELOG.mdb6e5603
Merge pull request #558 from kesne/patch-13ff1bf4
Prepre for releasev3.4.7
734b4fd
Merge pull request #533 from danger/greenkeeper/json5-1.0.0a84a955
Merge pull request #535 from danger/greenkeeper/flow-bin-0.68.019b9e09
Merge pull request #527 from danger/greenkeeper/get-stdin-6.0.00b8bc86
Merge pull request #520 from danger/greenkeeper/lint-staged-7.0.00964489
Update dev deps19d3458
Update octokit199598b
Update OctoKit4fa31ba
Remove the danger -> danger ci warning, it's been long enough3059d8e
Update node-fetch to 2.0fdfee11
Use null instead of undefined for node fetch8e74818
Update CHANGELOG9e1e296
Fix testsbd6f6b4
Improve the feedback on STDIN3eb635c
Merge pull request #559 from danger/update_deps16f7d287
Make a releasev3.5.0
783fe7e
chore(package): update flow-bin to version 0.70.0afd8255
fix empty comment77d17df
Add changelog entry840867f
fix bug when commiting .png files on BitBucketdf9aca9
Merge pull request #566 from ionutmiftode/mifi/bitbucket-check-hunks554e9e8
Merge branch 'master' into fix-empty-comment46e2a97
Inline API implemetation5724fb8
Platform Implementation for Bitbucket Inline changes641af10
Convert Bitbucket diff to Git Diff150eab0
Bitbucket inline template changes0dc3076
fix test casesb14f714
Added tests287b044
Cleanup code893696f
Change declarationdbb285f
Add changelog entry81db75b
change template6d416f2
fix review comments22b4ca0
Merge empty comment fix changes pull #5645858298
Merge pull request #564 from codestergit/fix-empty-comment9e564ee
Prepre for releasev3.5.1
0beb915
Merge branch 'master' into bitbucket-inlinedef0595
Merge pull request #560 from codestergit/bitbucket-inline515f258
Prepre for releaseThis PR has been generated by Renovate Bot.