Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency danger to v3.5.1 #86

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 21, 2018

This Pull Request updates dependency danger from v3.3.2 to v3.5.1

Release Notes

v3.4.0

  • Adds support for inline comments when using GitHub.

    This is one of those "massive under the hood" changes, that has a tiny user DSL surface. From this point onwards
    fail, warn, message and markdown all take an extra two optional params: file?: string and line?: number.

    Adding file and line to the call of any exported communication function will trigger one of two things:

    • Danger will create a new comment inline inside your PR with your warning/message/fail/markdown
    • Danger will append a in the main Danger comment with your warning/message/fail/markdown

    Inline messages are edited/created/deleted with each subsequent run of danger ci in the same way the main comment
    does. This is really useful for: linters, test runners and basically anything that relies on the contents of a file
    itself.

    If you're using danger process to communicate with an external process, you can return JSON like:

    {
      "markdowns": [
        {
          "file": "package.swift",
          "line": 3,
          "message": "Needs more base"
        }
      ]
      // [...]
    }

    -- [@​sunshinejr][]

  • Adds a data validation step when Danger gets results back from a process . [@​orta][]


v3.4.1

  • Protection against nulls in the inline comment data [@​orta][]

v3.4.2

  • Improving reporting when multiple violations are o nthe same line of a file [@​sunshinejr][]

v3.4.3

  • Fixed a bug where updating multiple inline comments caused a Javascript error [@​sunshinejr][]

v3.4.4

  • Fixed a bug where Danger would get access to all inline comments, thus deleting comments posted by other people
    [@​sunshinejr][]

v3.4.5

  • Don't print error for commit status when there was no error [@​sunshinejr][]

v3.4.6

  • Fixed Babel 7 breaking due to invalid sourceFileName configuration [@​kesne][]

v3.4.7

  • Update dependencies [@​orta][]

v3.5.0

  • Fixed a bug where Danger posts empty main comment when it have one or more inline comments to post [@​codestergit][]
  • fix bug when commiting .png files on BitBucket [@​Mifi][]
  • Adds support for inline comments for bitbucket server. [@​codestergit][]

v3.5.1

  • Fixed a bug where Danger posts empty main comment when it have one or more inline comments to post [@​codestergit][]
  • fix bug when commiting .png files on BitBucket [@​Mifi][]
  • Adds support for inline comments for bitbucket server. [@​codestergit][]

Commits

v3.4.0

  • 484671d Adds changelog + some light docs
  • 73e49bd Merge master
  • 674610b Pass the danger ID along
  • b1ce78c Test out the inline on danger
  • 62ad270 Update repo slug for GithubAPI to be a base instead of pr
  • 5fc6d66 Add logging for inline comments
  • 1499ed6 Remove the testing inline messages
  • dd7ed3b Convert console.logs to debug
  • 8b72d0f Remove some console logs
  • 0c7e7d7 Merge pull request #​529 from sunshinejr/file_line_api
  • 02dd89c Adds support for a validation step on the danger resutls
  • a31bdf0 Merge pull request #​548 from danger/validate
  • 9965176 Prepare for a release
  • a49c379 Remove the isInline function from being classed as a part of the danger DSL

v3.4.1

v3.4.2

v3.4.3

  • 9ef1013 Fix a bug with multiple updates for the inline comment
  • 2e36e21 Add Changelog entry
  • 2418999 Merge pull request #​551 from danger/inline_mode_fix_2
  • 069a617 Release

v3.4.4

  • 697ef32 Fix a bug where Danger would get all inline comments
  • 450d42b Add test cases for danger getting inline comments from api
  • d70631a Add Changelog entry
  • 13e4eb2 Merge pull request #​553 from danger/inline_mode_fix_3
  • cb2994f 3.4.4

v3.4.5

  • 2a4ca06 Don't print error for commit status when there was no error
  • 71aa70a Merge pull request #​555 from danger/sunshinejr-patch-1
  • b4e86ff 3.4.5

v3.4.6

  • 8265595 Remove deprecated babel 7 sourceMapTarget
  • 89ffbb2 Update CHANGELOG.md
  • b6e5603 Merge pull request #​558 from kesne/patch-1
  • 3ff1bf4 Prepre for release

v3.4.7

  • 734b4fd Merge pull request #​533 from danger/greenkeeper/json5-1.0.0
  • a84a955 Merge pull request #​535 from danger/greenkeeper/flow-bin-0.68.0
  • 19b9e09 Merge pull request #​527 from danger/greenkeeper/get-stdin-6.0.0
  • 0b8bc86 Merge pull request #​520 from danger/greenkeeper/lint-staged-7.0.0
  • 0964489 Update dev deps
  • 19d3458 Update octokit
  • 199598b Update OctoKit
  • 4fa31ba Remove the danger -> danger ci warning, it's been long enough
  • 3059d8e Update node-fetch to 2.0
  • fdfee11 Use null instead of undefined for node fetch
  • 8e74818 Update CHANGELOG
  • 9e1e296 Fix tests
  • bd6f6b4 Improve the feedback on STDIN
  • 3eb635c Merge pull request #​559 from danger/update_deps1
  • 6f7d287 Make a release

v3.5.0

  • 783fe7e chore(package): update flow-bin to version 0.70.0
  • afd8255 fix empty comment
  • 77d17df Add changelog entry
  • 840867f fix bug when commiting .png files on BitBucket
  • df9aca9 Merge pull request #​566 from ionutmiftode/mifi/bitbucket-check-hunks
  • 554e9e8 Merge branch 'master' into fix-empty-comment
  • 46e2a97 Inline API implemetation
  • 5724fb8 Platform Implementation for Bitbucket Inline changes
  • 641af10 Convert Bitbucket diff to Git Diff
  • 150eab0 Bitbucket inline template changes
  • 0dc3076 fix test cases
  • b14f714 Added tests
  • 287b044 Cleanup code
  • 893696f Change declaration
  • dbb285f Add changelog entry
  • 81db75b change template
  • 6d416f2 fix review comments
  • 22b4ca0 Merge empty comment fix changes pull #​564
  • 5858298 Merge pull request #​564 from codestergit/fix-empty-comment
  • 9e564ee Prepre for release

v3.5.1

  • 0beb915 Merge branch 'master' into bitbucket-inline
  • def0595 Merge pull request #​560 from codestergit/bitbucket-inline
  • 515f258 Prepre for release

This PR has been generated by Renovate Bot.

@react-tether-bot
Copy link

react-tether-bot commented Apr 21, 2018

Messages
📖

Hey @renovate[bot], thanks for submitting a pull request! 😸

📖

🤔 Hmmm, code coverage is looking low for the whole codebase.

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/react-tether.js (0/0) 100% (0/0) 100% (0/0) 100% (0/0) 100%
src/TetherComponent.jsx (67/80) 84% (67/80) 84% (17/24) 71% (35/46) 76%
Total (67/80) 84% (67/80) 84% (17/24) 71% (35/46) 76%

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented Apr 21, 2018

Pull Request Test Coverage Report for Build 132

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.952%

Totals Coverage Status
Change from base Build 130: 0.0%
Covered Lines: 67
Relevant Lines: 80

💛 - Coveralls

@danreeves danreeves closed this Apr 21, 2018
@danreeves danreeves deleted the renovate/danger-3.x branch April 21, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants