Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine_latest, common transformer using the base combine transformer #29

Closed

Conversation

frankpepermans
Copy link
Contributor

No description provided.

@danschultz
Copy link
Owner

I'm thinking that maybe instead of having an additional combiner transformer, we can make the combiner arg in Combine be optional, and if it's not passed then it'll default to combining elements into a list.

@frankpepermans
Copy link
Contributor Author

I was thinking too much in the Frappe lib mindset, which is the actual one I'm using, it would be easy to just add a _latest function there that passes a predefined function :)

@danschultz
Copy link
Owner

Ok, closing this in favor of an optional Combiner arg. I filed issue #30 here for anyone interested in tracking its progress.

@danschultz danschultz closed this Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants