Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of UUID #24

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Better handling of UUID #24

merged 1 commit into from
Mar 27, 2018

Conversation

danschultzer
Copy link
Owner

@danschultzer danschultzer commented Mar 26, 2018

Resolves #23

Currently, ExOAuth2Provider won't work if the UUID schema hasn't been compiled already. This proposed change will do the following:

  1. Don't make an assumption of foreign_key_type for the resource owner, but instead allow for the foreign_key_type to be set in the config like so:
config :ex_oauth2_provider, ExOauth2Provider,
  resource_owner: {MyApp.User, :binary_id}
  1. Built in UUID schema that can be used instead of provided schema. This can be set like so:
config :ex_oauth2_provider, ExOauth2Provider,
  resource_owner: {MyApp.User, :binary_id},
  app_schema: ExOauth2Provider.Schema.UUID
  1. Explicitly state in readme that any customization will require that the Schema file is compiled first

@danschultzer danschultzer force-pushed the uuid-handling branch 2 times, most recently from d77a768 to 861a1c0 Compare March 26, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant