fix: formatting #77
Closed
fix: formatting #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about formatting all the repo? it will prevent big changes in future contribution. |
|
I don't use the mix formatter as I feel it makes the code less readable (I don't believe elixir/phoenix/ecto is using it either), but I do agree it would be much better if we can conform the formatting. I'll look into formatter configuration, but last time I checked the issue was that it didn't deal with whitespace at all as the formatter converts all code to AST (I believe). There are some good changes in this PR though that I want to pick out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.