tbody with class does not make it to output #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backspace
added a commit
to backspace/adventures
that referenced
this pull request
Apr 4, 2023
The classes were only there for ease of selection via test page objects, but even data attributes caused the tbody to not be output when the HTML was converted to text. danschultzer/premailex#80
|
I still can’t figure out where attributes would be causing a problem. I also found that a |
|
Thanks, didn't realize that there was a match on the attributes. I've fixed it now and added a test that ensures this get caught in the future for any new elements or during refactors. |
danschultzer
force-pushed
the
tbody-with-class
branch
from
bc1c669
to
fc690a5
Compare
danschultzer
force-pushed
the
tbody-with-class
branch
from
fc690a5
to
2631242
Compare
|
v0.3.18 is out with this fix! |
|
thank you 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends the existing test to show that a
tbodywith aclassattribute is not part of the final output. I didn’t immediately see what might be needed to get this working but I’ll look at it more in the future 🤞🏻