No unit tests

[alois-git]

Hi,

I have used this library in a personal project and after looking at the code I see that there is no unit tests which is ... ;) I was going to make some but I already had to change the project structure to match the correct maven structur and do quite a lot of refactoring to have classes that are testables.

Are you willing to merge big changes ? or should I just stop ? :)

Regards,

Alokhan

[danshannon]

Hi Alokhan The unit tests have always lived in a separate project - there are a couple of thousand tests that exercise just about everything, plus automated bean testing, and a bunch of tests that check whether bugs in the Strava API are fixed yet Sorry to be slow to reply - I’m not really able to manage the project any more, but it would be great for it to live on. Do you want me to make you a committee? Let me know Cheers Dan

…

On Sat, 5 Jan 2019 at 6:58 am, Alois ***@***.***> wrote: Hi, I have used this library in a personal project and after looking at the code I see that there is no unit tests which is ... ;) I was going to make some but I already had to change the project structure to match the correct maven structur and do quite a lot of refactoring to have classes that are testables. Are you willing to merge big changes ? or should I just stop ? :) Regards, Alokhan — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#192>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdIJMELhLGzi9M60Bp_s8hkaTftk_0Bks5u_7KDgaJpZM4Zscn-> .

[alois-git]

Hi,

Yes I would be interested, and if you can provide the test sources I would be interested as well :)

EDIT: nvm I found the test project on your github :)

Regards,

Alokhan