Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve Error message when missing secrets #149

Closed
dansiegel opened this issue Oct 2, 2020 · 1 comment
Closed

[Enhancement] Improve Error message when missing secrets #149

dansiegel opened this issue Oct 2, 2020 · 1 comment
Milestone

Comments

@dansiegel
Copy link
Owner

SUMMARY

Since we now know what secrets are expected for a given project, the Secrets Class Generator should fail with error messages for each property that is missing.

DETAILS

Given a configuration like the following

"projectSecrets": {
  "BuildToolsSample": {
    "className": "Settings",
    "namespace": "Helpers",
    "properties": [
      {
        "name": "AppCenterId",
        "type": "String"
      }
    ]
  }
}

We should see a build error like:

Missing Secret value for 'AppCenterId' when the property has not been defined in the secrets.json

PLATFORMS

n/a

@dansiegel dansiegel added this to the v2.0 milestone Oct 2, 2020
@dansiegel
Copy link
Owner Author

This is resolved in the latest build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant