Exclude materials with too small covers from Related Materials app #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the case if a cover exists for the object but the original is smaller than the requested size.
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 80.81% 81.02% +0.21%
==========================================
Files 47 47
Lines 641 643 +2
Branches 151 148 -3
==========================================
+ Hits 518 521 +3
+ Misses 112 111 -1
Partials 11 11
Continue to review full report at Codecov.
|
We require a certain size of the cover images we retrieve. If the image is not large enough it may not display right on certain devices. Consequently they should be removed for now. Without this a related material will have a cover image with null as src. This is just displayed as a blank space. Expand tests accordingly.
kasperg
force-pushed
the
related-materials-filter-covers
branch
from
5af93ce
to
adacbb4
Compare
cableman
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We require a certain size of the cover images we retrieve. If the
image is not large enough it may not display right on certain
devices. Consequently they should be removed for now.
Without this a related material will have a cover image with null as
src. This is just displayed as a blank space.
For good measure we also update the JSDoc to show that the url can
be null.
Before
After