-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 3DSv2 and implement recovery, cancel and refund #13
Conversation
@zevran So far so good, the websites where I need the interface are working fine. I don't know if it's really important : on PHP5.6, I've an issue because AddressBilling & AddressShipping requires string arguments. But it throws a recoverable error because arguments are not instances of "DansMaCulotte\Monetico\Resources\string". But I do not have this issue on PHP7+. No biggie though, everything else goes right on PHP7+ :D |
And I confirm it's only for PHP below 7 : I've upgrade the version used to test and these issues disappeared. |
@LupusVII the problem should be resolved for Method interface but for PHP I prefer to prevent older versions than |
And it's okay, I've put the customer website on PHP7 and it's fine for now. |
This PR implements the following features :
@martinpotel learned how to publish work for oss projects, congrats to him !
@LupusVII, if you can to take a look and give us some feedback it would be great !
NB: Previous PRs (#8, #9, #10, #11, #12) have been closed because it was a mess 馃槄