Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3DSv2 and implement recovery, cancel and refund #13

Merged
merged 40 commits into from
Jul 24, 2019
Merged

Conversation

gaelreyrol
Copy link
Contributor

@gaelreyrol gaelreyrol commented Jul 23, 2019

This PR implements the following features :

@martinpotel learned how to publish work for oss projects, congrats to him !
@LupusVII, if you can to take a look and give us some feedback it would be great !

NB: Previous PRs (#8, #9, #10, #11, #12) have been closed because it was a mess 馃槄

@gaelreyrol gaelreyrol added the enhancement New feature or request label Jul 23, 2019
@gaelreyrol gaelreyrol added this to the v1.0 milestone Jul 23, 2019
@gaelreyrol gaelreyrol self-assigned this Jul 23, 2019
@gaelreyrol gaelreyrol requested a review from a team July 23, 2019 21:06
@gaelreyrol gaelreyrol assigned martinpotel and unassigned gaelreyrol Jul 23, 2019
@LupusVII
Copy link

@zevran So far so good, the websites where I need the interface are working fine.

I don't know if it's really important : on PHP5.6, I've an issue because AddressBilling & AddressShipping requires string arguments. But it throws a recoverable error because arguments are not instances of "DansMaCulotte\Monetico\Resources\string". But I do not have this issue on PHP7+.
One another, PHP5.6 only : I've an error with the interface "DansMaCulotte\Monetico\method" : it's not found because it's not PascalCase haha.

No biggie though, everything else goes right on PHP7+ :D

@LupusVII
Copy link

And I confirm it's only for PHP below 7 : I've upgrade the version used to test and these issues disappeared.

@gaelreyrol gaelreyrol marked this pull request as ready for review July 24, 2019 12:14
@gaelreyrol
Copy link
Contributor Author

@LupusVII the problem should be resolved for Method interface but for PHP I prefer to prevent older versions than 7.0 for compatibility reasons.

@gaelreyrol gaelreyrol merged commit f265bd8 into master Jul 24, 2019
@gaelreyrol gaelreyrol deleted the 3DSv2 branch July 24, 2019 12:31
@LupusVII
Copy link

And it's okay, I've put the customer website on PHP7 and it's fine for now.
Good job, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants