Build failed: thread 'main' panicked at '"__atomic_wide_counter_struct_(unnamed_at_/usr/include/bits/atomic_wide _counter_h_28_3)" is not a valid Ident'

[powerman]

This happens on latest master compiled by rustc 1.69.0 (84c898d65 2023-04-16):

...
   Compiling tokio-tower v0.6.0
     Running `rustc --crate-name tokio_tower --edition=2018 /var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/cargo_home/gentoo/tokio-tower-0.6.0/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 --cfg 'feature="default"' -C metadata=5c9a86f958329f31 -C extra-filename=-5c9a86f958329f31 --out-dir /var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps -L dependency=/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps --extern crossbeam=/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps/libcrossbeam-967044c6553c2788.rmeta --extern futures_core=/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps/libfutures_core-4da00d997dd66617.rmeta --extern futures_sink=/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps/libfutures_sink-a26a4abef28b5d2e.rmeta --extern futures_util=/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps/libfutures_util-8f771a47350f7ae2.rmeta --extern pin_project=/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps/libpin_project-8e1069d969a2b7f1.rmeta --extern tokio=/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps/libtokio-230dde33a03cca06.rmeta --extern tower=/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps/libtower-1f05121e2189ca8c.rmeta --extern tower_service=/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps/libtower_service-538115adcd897e7c.rmeta --extern tracing=/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/deps/libtracing-609e7068b8b0de39.rmeta --cap-lints allow`
error: failed to run custom build command for `uhid-sys v1.0.0 (/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/linux/uhid-sys)`

Caused by:
  process didn't exit successfully: `/var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/rust-u2f-da1a256e804395588c21c0dd9891310506746e7a/target/debug/build/uhid-sys-610c68906284c792/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at '"__atomic_wide_counter_struct_(unnamed_at_/usr/include/bits/atomic_wide_counter_h_28_3)" is not a valid Ident', /var/tmp/portage/app-crypt/rust-u2f-0.4.2_p20221104/work/cargo_home/gentoo/proc-macro2-1.0.47/src/fallback.rs:756:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[powerman]

Upgrading bindgen to 0.65.1 fixes the issue.
Patch: https://github.com/powerman/powerman-overlay/blob/master/app-crypt/rust-u2f/files/deps-update-bindgen.patch

[M1CK431]

@powerman @kousu I can confirm that it build after bumping bindgen using Archlinux (I modify the pkgbuild to use the patched version from @Konsu).

However, the software itself doesn't works as expected.
I can enable/start the socket:

# systemctl status softu2f.socket
● softu2f.socket
     Loaded: loaded (/usr/lib/systemd/system/softu2f.socket; enabled; preset: enabled)
     Active: active (listening) since Mon 2023-09-11 21:58:33 CEST; 7min ago
   Triggers: ● softu2f.service
     Listen: /run/softu2f/softu2f.sock (Stream)
     CGroup: /system.slice/softu2f.socket

sept. 11 21:58:33 envy systemd[1]: Listening on softu2f.socket.

But when I try to enable/start the user service:

$ systemctl --user status softu2f.service 
○ softu2f.service - Software-only U2F Emulation Service
     Loaded: loaded (/usr/lib/systemd/user/softu2f.service; enabled; preset: enabled)
     Active: inactive (dead) since Mon 2023-09-11 22:03:20 CEST; 11min ago
   Duration: 8ms
    Process: 448221 ExecStart=/usr/lib/softu2f/user-daemon (code=exited, status=0/SUCCESS)
   Main PID: 448221 (code=exited, status=0/SUCCESS)
        CPU: 10ms

sept. 11 22:03:20 envy systemd[746]: Started Software-only U2F Emulation Service.
sept. 11 22:03:20 envy user-daemon[448221]: Starting rust-u2f user daemon
sept. 11 22:03:20 envy user-daemon[448221]: Storing secrets in an unencrypted file
sept. 11 22:03:20 envy user-daemon[448221]: registering event source with poller: token=Token(1), interests=READABLE | WRITABLE
sept. 11 22:03:20 envy user-daemon[448221]: deregistering event source from poller
sept. 11 22:03:20 envy user-daemon[448221]: Error encountered, exiting: I/O error: Expected socket peer to be running as root user

Obviously, the socket is running as root:

# ls -l /run/softu2f/softu2f.sock
srw-rw-rw- 1 root root 0 11 sept. 21:58 /run/softu2f/softu2f.sock

Is this issue linked to your patch? Or perhaps there is more changes to do after bumping bindgen? wdyt?

[danstiner]

Thanks for the report, updated bindgen in 30160e0#diff-a4051fcf5e0564c6e629966aa79e84248aa36d26e1b21cc2a9dbcbab07032661

The socket peer error was #116, which is also fixed now.

[M1CK431]

I just test it by changing my pkgbuild to use the latest commit (da1c12d) and it works now! 👏🏼

@grawity could you please upgrade the AUR pkgbuild? 🥺