Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] .status-comments doesn't need a fixed height #156

Closed
trwnh opened this issue Jun 3, 2018 · 3 comments
Closed

[UI] .status-comments doesn't need a fixed height #156

trwnh opened this issue Jun 3, 2018 · 3 comments
Assignees
Labels
👀 UI An issue with the interface / frontend

Comments

@trwnh
Copy link
Member

trwnh commented Jun 3, 2018

Since the image container is now using a block model (display: block), you no longer have to set an explicit height for the comments section. Disabling that rule actually makes the cards look better. For example:

URL Before After
https://pixelfed.social/p/deadsuperhero/1041 image image
@DeadSuperHero
Copy link
Contributor

DeadSuperHero commented Jun 3, 2018

Damn, I've actually been trying to accomplish the After image through alternate means; this is a way better approach.

@trwnh
Copy link
Member Author

trwnh commented Jun 3, 2018

@DeadSuperHero Blame it on Bootstrap! It's pretty straightforward and not at all confusing when the UI is written from scratch :P In the block model, everything is already a block, and containers expand to fit their contents.

@dansup dansup self-assigned this Jun 3, 2018
@dansup dansup added the 👀 UI An issue with the interface / frontend label Jun 3, 2018
@trwnh trwnh closed this as completed Jun 3, 2018
@trwnh trwnh reopened this Jun 3, 2018
@trwnh
Copy link
Member Author

trwnh commented Jun 3, 2018

Should be fixed as soon as #162 is deployed!

@dansup dansup closed this as completed in 6c0817a Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 UI An issue with the interface / frontend
Projects
None yet
Development

No branches or pull requests

3 participants