Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation for optional data structures #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FoxxMD
Copy link

@FoxxMD FoxxMD commented Jan 10, 2024

Plex does not return volume which causes MediaController.getStatus to throw an error due to zod validation failing, but the api call did succeed.

I suspect other applications may also not allow volume control.

My google home mini does not present any applications when nothing is running (audio only device)
@FoxxMD FoxxMD changed the title fix: make media status volume nullish fix: validation for optional data structures Jan 12, 2024
@FoxxMD
Copy link
Author

FoxxMD commented Jan 12, 2024

Added an additional commit -- my google home mini does not present any applications when nothing is running. This might be because its an audio only device vs. a tv which has a "Backdrop"/idle screen application when nothing is running so an application is always present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant