Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails to load .svg, .webp wallpaper #48

Closed
cmoog opened this issue Feb 28, 2023 · 3 comments · Fixed by #56
Closed

fails to load .svg, .webp wallpaper #48

cmoog opened this issue Feb 28, 2023 · 3 comments · Fixed by #56
Labels
bug Something isn't working properly

Comments

@cmoog
Copy link

cmoog commented Feb 28, 2023

Fails to build when stylix.image is set to a .svg or .webp asset. This is especially frustrating because it seems to fail even when the base16Scheme is set manually.

Error log

       last 10 log lines:
       > Jpeg Invalid marker used
       > PNG Invalid PNG file, signature broken
       > Bitmap Invalid Bitmap magic identifier
       > GIF Invalid Gif signature : <svg w
       > HDR Invalid radiance file signature
       > Tiff Invalid endian tag value
       > TGA not enough bytes
       >
       > CallStack (from HasCallStack):
       >   error, called at Stylix/Main.hs:22:26 in main:Main
@cmoog cmoog changed the title fails to load .svg wallpaper fails to load .svg, .webp wallpaper Feb 28, 2023
@danth
Copy link
Owner

danth commented Feb 28, 2023

Setting base16Scheme should disable the palette generator, so I'm not sure why that is still running.

@dwarfmaster
Copy link
Contributor

It's still running because it is linked from /etc/stylix/palette.json, I will try to see if I can fix that later.

@dwarfmaster dwarfmaster added the bug Something isn't working properly label Feb 28, 2023
@dwarfmaster
Copy link
Contributor

dwarfmaster commented Mar 7, 2023

Ok so the problem is that we want to store the generated palette to make sur it isn't garbage collected (in which case the generation will be run again even if nothing changed). The drawback of the current setup is that it always evaluates the generated scheme. I am not sure how to detect if the theme has been generated or not without running the generation, so I think I'll have to add an explicit option to disable generation.
EDIT: turns out I found a way to do it, see #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants