-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement _check #21
Implement _check #21
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,45 @@ | ||
exports._check = () => { | ||
// DRY up the codebase with this function | ||
// First, move the duplicate error checking code here | ||
// Then, invoke this function inside each of the others | ||
// HINT: you can invoke this function with exports._check() | ||
}; | ||
exports._check = (x, y) => { | ||
|
||
if (typeof x !== 'number') { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Expected indentation of 2 spaces but found 4. See http://eslint.org/docs/rules/indent for details about this rule |
||
throw new TypeError(`${x} is not a number`); | ||
} | ||
|
||
if (typeof y !== 'number') { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Expected indentation of 2 spaces but found 4. See http://eslint.org/docs/rules/indent for details about this rule |
||
throw new TypeError(`${y} is not a number`); | ||
} | ||
|
||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Block must not be padded by blank lines. See http://eslint.org/docs/rules/padded-blocks for details about this ruleThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing semicolon. See http://eslint.org/docs/rules/semi for details about this rule |
||
|
||
|
||
exports.add = (x, y) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Block must not be padded by blank lines. See http://eslint.org/docs/rules/padded-blocks for details about this rule |
||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); | ||
} | ||
if (typeof y !== 'number') { | ||
throw new TypeError(`${y} is not a number`); | ||
} | ||
|
||
exports._check(x, y); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Expected indentation of 2 spaces but found 0. See http://eslint.org/docs/rules/indent for details about this rule |
||
|
||
return x + y; | ||
|
||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Block must not be padded by blank lines. See http://eslint.org/docs/rules/padded-blocks for details about this rule |
||
|
||
exports.subtract = (x, y) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Block must not be padded by blank lines. See http://eslint.org/docs/rules/padded-blocks for details about this rule |
||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); | ||
} | ||
if (typeof y !== 'number') { | ||
throw new TypeError(`${y} is not a number`); | ||
} | ||
|
||
exports._check(x, y); | ||
|
||
return x - y; | ||
|
||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Block must not be padded by blank lines. See http://eslint.org/docs/rules/padded-blocks for details about this rule |
||
|
||
exports.multiply = (x, y) => { | ||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); | ||
} | ||
if (typeof y !== 'number') { | ||
throw new TypeError(`${y} is not a number`); | ||
} | ||
exports._check(x, y); | ||
|
||
return x * y; | ||
|
||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Block must not be padded by blank lines. See http://eslint.org/docs/rules/padded-blocks for details about this rule |
||
|
||
exports.divide = (x, y) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Block must not be padded by blank lines. See http://eslint.org/docs/rules/padded-blocks for details about this rule |
||
if (typeof x !== 'number') { | ||
throw new TypeError(`${x} is not a number`); | ||
} | ||
if (typeof y !== 'number') { | ||
throw new TypeError(`${y} is not a number`); | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Trailing spaces not allowed. See http://eslint.org/docs/rules/no-trailing-spaces for details about this rule |
||
exports._check(x, y); | ||
|
||
return x / y; | ||
|
||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Block must not be padded by blank lines. See http://eslint.org/docs/rules/padded-blocks for details about this rule |
||
|
||
module.exports = exports; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Block must not be padded by blank lines.
See http://eslint.org/docs/rules/padded-blocks for details about this rule