Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue dry up codebase #2194

Closed

Conversation

admalik100
Copy link

Implemented the changes for #1

  • Replaced skip tag and added only tag for the tests to run
  • Improved the error check logic to avoid duplication of code

@dantharejabot
Copy link
Collaborator

Thanks for the submission, @admalik100.

As mentioned in the contributing guidelines, I can only accept a pull request made to your branch.

This is a weird requirement, but it's necessary here in order to allow multiple people to contribute the same code. In the real world, most projects would expect you to open a Pull Request against the master base branch.

Click here to open this pull request to your branch

Want to contribute to the master branch? Open an issue in the partner repo and let's talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants