Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement _check #515

Closed
wants to merge 1 commit into from
Closed

Conversation

ryanfuhrman
Copy link

Fixed DRY issue.

Implemented _check function in calculator.js to remove repeated test code in each operator (add, subtract, etc.) function.

@dantharejabot
Copy link
Collaborator

Thanks for the submission, @ryanfuhrman.

As mentioned in the contributing guidelines, I can only accept a pull request made to your branch. This behavior deviates from most projects (where a pull request to the master branch may be expected) in order to replicate this experience for multiple people.

Click here to open this pull request to your branch

Want to contribute to the master branch? Open an issue in the partner repo and let's talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRY up the codebase
2 participants