Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help is not included when using pyinstaller #69

Closed
shughes-uk opened this issue Dec 3, 2019 · 2 comments · Fixed by #72
Closed

Help is not included when using pyinstaller #69

shughes-uk opened this issue Dec 3, 2019 · 2 comments · Fixed by #72

Comments

@shughes-uk
Copy link
Contributor

shughes-uk commented Dec 3, 2019

I'm having an issue when creating a python binary using Pyinstaller. It does not include the site module , which is where help comes from. This results in a NameError when importing simpleeval. As including site seems like it would cause Pyinstaller significant issues it might be wise to check for it's existence before adding it to your excluded keywords list in simpleeval.

The relevant code is DISALLOW_FUNCTIONS = {type, isinstance, eval, getattr, setattr, help, repr, compile, open}

Here's a pyinstaller issue I was able to find that is related.

pyinstaller/pyinstaller#4448

If you feel this is a pyinstaller issue I can recreate this issue over there.

@danthedeckie
Copy link
Owner

Nice catch @shughes-uk ! And awesome creating a PR for it too 😄

I put a suggested change in the PR.

@Toilal
Copy link

Toilal commented Feb 15, 2021

Hi @danthedeckie, could you perform a release including this fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants