Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIOperation does not finish #186

Merged
merged 1 commit into from
Feb 11, 2016

Conversation

danthorpe
Copy link
Member

UIOperation does not actually finish after it does the presentation. But it does accept a completion block. This is all a bit strange. There is no need for a completion block, and instead, it should just finish().

@danthorpe danthorpe added the bug label Feb 11, 2016
@danthorpe danthorpe self-assigned this Feb 11, 2016
@danthorpe danthorpe added this to the 2.6 milestone Feb 11, 2016
@codecov-io
Copy link

Current coverage is 74.30%

Merging #186 into development will increase coverage by +0.01% as of b409689

@@            development   #186   diff @@
==========================================
  Files                51     51       
  Stmts              3240   3242     +2
  Branches              0      0       
  Methods                              
==========================================
+ Hit                2407   2409     +2
  Partial               0      0       
  Missed              833    833       

Review entire Coverage Diff as of b409689

Powered by Codecov. Updated on successful CI builds.

danthorpe added a commit that referenced this pull request Feb 11, 2016
@danthorpe danthorpe merged commit e323b63 into development Feb 11, 2016
@danthorpe danthorpe deleted the feature/OPR-186_finish_ui_operation branch February 12, 2016 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants