You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are minor, opinion-based reorganizations with no functional change; thus this PR may be closed with no hard feelings if this code churn is undesirable.
d21165b separates YapDB.Index's Hashable and CustomStringConvertible implementations; they're not really related and it took me a moment to realize there wasn't a reason for them to be grouped together like that.
8df385e groups free functions operating on Persistables alongside the Persistable protocol definition, as so:
This minor reorganization just makes reading the implementation a little clearer, IMO. This is not a functional change, so rejection of this change would be understandable.
This results in the following structure in Xcode, wherein free functions operating on Persistable are grouped with the Persistable definition:
This minor reorganization just makes reading the implementation a little clearer, IMO. This is not a functional change, so rejection of this change would be understandable.
Yeah, I think it's okay now, last one is just testing on iOS. There were some issues with Carthage on the build machines, seems to have resolved itself now.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are minor, opinion-based reorganizations with no functional change; thus this PR may be closed with no hard feelings if this code churn is undesirable.
d21165b separates
YapDB.Index'sHashableandCustomStringConvertibleimplementations; they're not really related and it took me a moment to realize there wasn't a reason for them to be grouped together like that.8df385e groups free functions operating on
Persistables alongside the Persistable protocol definition, as so: