fix(options): remove the limit varibale

never defaulted to zero
danvergara · Jun 21, 2022 · 348e4b3 · 348e4b3
1 parent 36f3a18
commit 348e4b3
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 10 deletions.
diff --git a/cmd/root.go b/cmd/root.go
@@ -21,7 +21,6 @@ var (
 	pass   string
 	db     string
 	ssl    string
-	limit  int
 )
 
 // NewRootCmd returns the root command.
@@ -49,7 +48,6 @@ func NewRootCmd() *cobra.Command {
 					Pass:   pass,
 					DBName: db,
 					SSL:    ssl,
-					Limit:  limit,
 				}
 
 				if form.IsEmpty(opts) {
@@ -108,5 +106,4 @@ func init() {
 	rootCmd.Flags().StringVarP(&pass, "pass", "", "", "Password for user")
 	rootCmd.Flags().StringVarP(&db, "db", "", "", "Database name")
 	rootCmd.Flags().StringVarP(&ssl, "ssl", "", "", "SSL mode")
-	rootCmd.Flags().IntVarP(&limit, "limit", "", 100, "Size of the result set from the table content query")
 }
diff --git a/pkg/client/client.go b/pkg/client/client.go
@@ -21,7 +21,6 @@ import (
 type Client struct {
 	db     *sqlx.DB
 	driver string
-	limit  int
 }
 
 // New return an instance of the client.
@@ -39,7 +38,6 @@ func New(opts command.Options) (*Client, error) {
 	c := Client{
 		db:     db,
 		driver: opts.Driver,
-		limit:  opts.Limit,
 	}
 
 	return &c, nil

diff --git a/pkg/client/client_test.go b/pkg/client/client_test.go
@@ -156,7 +156,6 @@ func TestTableContent(t *testing.T) {
 		Port:   port,
 		DBName: name,
 		SSL:    "disable",
-		Limit:  100,
 	}
 
 	c, _ := New(opts)

diff --git a/pkg/command/command.go b/pkg/command/command.go
@@ -12,7 +12,6 @@ type Options struct {
 	Pass   string
 	DBName string
 	SSL    string
-	Limit  int
 }
 
 // SetDefault returns a Options struct and fills the empty

diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -31,7 +31,6 @@ type Config struct {
 		Driver   string `validate:"required"`
 		SSL      string `default:"disable"`
 	}
-	Limit  int `fig:"limit" default:"100"`
 	User   string
 	Pswd   string
 	Host   string
@@ -76,7 +75,6 @@ func Init() (command.Options, error) {
 		Pass:   cfg.Database.Password,
 		DBName: cfg.Database.DB,
 		SSL:    cfg.Database.SSL,
-		Limit:  cfg.Limit,
 	}
 
 	return opts, nil

diff --git a/pkg/config/config_test.go b/pkg/config/config_test.go
@@ -17,5 +17,4 @@ func TestInit(t *testing.T) {
 	assert.Equal(t, "postgres", opts.User)
 	assert.Equal(t, "password", opts.Pass)
 	assert.Equal(t, "postgres", opts.Driver)
-	assert.Equal(t, 50, opts.Limit)
 }