Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a small improvement to the installation script #219

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

danvergara
Copy link
Owner

Add a small improvement to the installation script

Description

There's an issue pointing out that installation script is not working, but I can't reproduce the error locally and the script is pretty much the same of the one in lazydocker. I found out that the maintainer did an improvement over the years and I just add it to the installation script on dblab.

Fixes #208

Type of change

Please delete options that are not relevant.

  • Chore (other changes that don't modify src or test files)

How Has This Been Tested?

Locally, with multiple parameters.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara added the kind/enhancement New feature or request label Jun 11, 2024
@danvergara danvergara self-assigned this Jun 11, 2024
@janpieper
Copy link

FYI #212 is also trying to fix #208

@danvergara
Copy link
Owner Author

FYI #212 is also trying to fix #208

hi @janpieper!

Thanks for reaching out.

I know, but that solution won't be accepted, and this solutions just implements the differences between the current script and the one I took inspiration from.

@danvergara danvergara merged commit c15ce42 into main Jun 20, 2024
8 checks passed
@danvergara danvergara deleted the improve-installation-script branch June 20, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux installation script not working right
3 participants