Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new description on new query params supported due to the sqlite drive change #221

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

danvergara
Copy link
Owner

Add a new description on new query params

Description

I realized that the query params for sqlite connection string are different than the ones that used to be supported because we change sqlite driver. I'm adding description on how to use them and reference to the new ones.

Fixes #220

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I tested this out locally using the database file we provide.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara self-assigned this Jun 12, 2024
@danvergara danvergara added kind/docs Improvements or additions to documentation kind/bugfix labels Jun 12, 2024
@ThiagoMowszet ThiagoMowszet self-requested a review June 18, 2024 17:41
Copy link
Collaborator

@ThiagoMowszet ThiagoMowszet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lo veo bien!
Se agradece los comentarios a la documentacion oficial para validar los query parameters.
💯🖖

@danvergara danvergara merged commit 14a5c47 into main Jun 20, 2024
8 checks passed
@danvergara danvergara deleted the fix-sqlite-connection-docs branch June 20, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bugfix kind/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: missing port in address using sqlite
2 participants