Custom drawing circles #123
Conversation
Conflicts: dygraph-canvas.js dygraph-utils.js
|
Odd, I thought I just pushed some bug fixes. Why aren't they there? |
|
OK, bug fixes are in. One bug remains, but review can start. |
| "drawPointCallback": { | ||
| "default": "null", | ||
| "labels": ["Data Line display"], | ||
| "type": "function(g, seriesName, canvasContext, cx, cy, color, pointSize)", |
There was a problem hiding this comment.
Either change cx -> x, cy -> y or clarify what the "c" stands for ("pointX", "pointY", "centerX", "centerY"?)
There was a problem hiding this comment.
Maybe this is a deficiency in the docs specification? What if I added
"params" : {
"cx" : "The x coordinate of the center of the image".
...
}
Also, I was thinking of replacing many (most? all?) of the external references to pointSize with radius. WDYT?
|
Ok, I'll pull. I understand why the overdrawing happens, but it still strikes me as unexpected behavior. But we can figure that out later. |
|
Regarding overdrawing, we should discuss. I think it's not as big a deal as you think; I could be wrong. Thanks for the pull. |
This includes tests, though no tests for the RegularConvex object. Perhaps a gallery entry? (I should finish up the gallery BTW)