Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to gulp & karma #565

Merged
merged 14 commits into from
Mar 23, 2015
Merged

Migrate to gulp & karma #565

merged 14 commits into from
Mar 23, 2015

Conversation

danvk
Copy link
Owner

@danvk danvk commented Mar 21, 2015

This is heavily based on (and supersedes) #528.

Highlights:

  • Moves all code into src/
  • Switches from jstd to Mocha, Chai and Karma.
  • Uses gulp for building

The upshot is that dygraph becomes a more modern JavaScript library and we can start using nice tools like Istanbul (for code coverage) and Babel (for ES6/7→ES5 transpilation).

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fbab47f on gulp into * on master*.

@danvk danvk force-pushed the gulp branch 2 times, most recently from 034807b to 08391a4 Compare March 22, 2015 22:52
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 08391a4 on gulp into * on master*.

@danvk
Copy link
Owner Author

danvk commented Mar 22, 2015

@kberg @klausw-g @flooey FYI

This is a fairly big change to dygraphs—see PR description. I'd like to merge this in relatively soon (tonight or tomorrow), so please let me know if you have any objections.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e8a0d6a on gulp into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b0ce973 on gulp into * on master*.

@danvk danvk mentioned this pull request Mar 23, 2015
8 tasks
@flooey
Copy link
Contributor

flooey commented Mar 23, 2015

It looks like this only changes the build process, not any of the code, right? If that's the case, it'll be a bit annoying to set up the next time we update our copy, but should be fine otherwise. Feel free to go ahead.

@danvk
Copy link
Owner Author

danvk commented Mar 23, 2015

That's correct. To get the same file as before, you run:

npm install
gulp dist
ls dist/dygraph-combined.js

dygraphs already depends on NPM, so this shouldn't be a big deal.

If anyone depends on individual JS files in dygraphs, they'll have to be updated. But I'd highly recommend not doing that. I plan to start using ES6 features soon, which will make these files not directly includable in the browser.

@danvk
Copy link
Owner Author

danvk commented Mar 23, 2015

Okie doke, this is going in.

danvk added a commit that referenced this pull request Mar 23, 2015
Migrate to gulp & karma
@danvk danvk merged commit 3123ca5 into master Mar 23, 2015
@mirabilos mirabilos deleted the gulp branch January 13, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants