-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to gulp & karma #565
Conversation
Changes Unknown when pulling fbab47f on gulp into * on master*. |
034807b
to
08391a4
Compare
Changes Unknown when pulling 08391a4 on gulp into * on master*. |
Changes Unknown when pulling e8a0d6a on gulp into * on master*. |
Changes Unknown when pulling b0ce973 on gulp into * on master*. |
It looks like this only changes the build process, not any of the code, right? If that's the case, it'll be a bit annoying to set up the next time we update our copy, but should be fine otherwise. Feel free to go ahead. |
That's correct. To get the same file as before, you run:
dygraphs already depends on NPM, so this shouldn't be a big deal. If anyone depends on individual JS files in dygraphs, they'll have to be updated. But I'd highly recommend not doing that. I plan to start using ES6 features soon, which will make these files not directly includable in the browser. |
Okie doke, this is going in. |
This is heavily based on (and supersedes) #528.
Highlights:
src/
The upshot is that dygraph becomes a more modern JavaScript library and we can start using nice tools like Istanbul (for code coverage) and Babel (for ES6/7→ES5 transpilation).