perf: Add benchmark and speedup #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 97.35% 97.35%
=======================================
Files 17 17
Lines 1925 1927 +2
Branches 317 317
=======================================
+ Hits 1874 1876 +2
Misses 50 50
Partials 1 1 ☔ View full report in Codecov by Sentry. |
danvk
added a commit
that referenced
this pull request
Feb 18, 2024
Another performance test that's not so stack intensive as Fibonacci (#37). Counting the primes less than 10,000: - gravlax: 36.7s - jlox: 11s - clox: 3.6s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36 at least to some extent!
Throwing a non-
Errorsubclass makes the Fibonacci benchmark ~6x faster:The difference for the 40th Fibonacci number is even more dramatic, ~2000s → 200s. Still slower than jlox's 27 seconds, but at least within an order of magnitude.
Thanks to https://github.com/davidhfriedman/jslox for the inspiration.