Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse non-contributing directories #137

Closed
daveisfera opened this issue Oct 30, 2019 · 3 comments · Fixed by #162, #167 or #178
Closed

Collapse non-contributing directories #137

daveisfera opened this issue Oct 30, 2019 · 3 comments · Fixed by #162, #167 or #178
Assignees
Milestone

Comments

@daveisfera
Copy link

Thanks for the work on this awesome tool!

Is your feature request related to a problem? Please describe.
Directories that don't contribute to the size are still shown as a layer in the treemap and this ends up hiding contributing layers when looking at multiple bundles in a single HTML file

Describe the solution you'd like
Directories that aren't contributing are combined or there's an option to enable this behavior

Describe alternatives you've considered
A way to hide/combine these non-contributing layers in the HTML file

Additional context
Screen Shot 2019-10-30 at 12 50 25 AM
I've attached a screenshot that shows the HTML of one of our bundles and you can see that webpack, ., ., src, and apps take up 5 layers in the treemap of the HTML before any meaningful content is reached and when looking at an HTML file that is analyzing multiple bundles, this makes several more meaningful layers end up being hidden and they have to be clicked on to see the useful info.

@nikolay-borzov nikolay-borzov added this to the 2.3.0 milestone Jan 2, 2020
@nikolay-borzov nikolay-borzov self-assigned this Feb 2, 2020
nikolay-borzov added a commit that referenced this issue Feb 15, 2020
- When building data for `webtreemap` join source parts that create intermediate nodes (nodes with single children)
- Add tests for `getWebTreeMapData`
nikolay-borzov added a commit that referenced this issue Feb 19, 2020
- When building data for `webtreemap` join source parts that create intermediate nodes (nodes with single children)
- Add tests for `getWebTreeMapData`
@daveisfera
Copy link
Author

Thanks!

@nikolay-borzov nikolay-borzov modified the milestones: 2.3.0, 2.3.1 Feb 19, 2020
nikolay-borzov added a commit that referenced this issue Feb 20, 2020
- Fix nodes collapsing logic. Take into account the path to the node when looking for nodes with the same root path
nikolay-borzov added a commit that referenced this issue Feb 20, 2020
- Fix nodes collapsing logic. Take into account the path to the node when looking for nodes with the same root path
@daveisfera
Copy link
Author

This is still happening for me (i.e. the entries under webpack are still showing up and not being collapsed)

nikolay-borzov added a commit that referenced this issue Mar 21, 2020
- Treat `webpack:///` as an atomic filename part
@nikolay-borzov nikolay-borzov modified the milestones: 2.3.1, 2.4.1 Mar 21, 2020
nikolay-borzov added a commit that referenced this issue Mar 21, 2020
- Treat `webpack:///` as an atomic filename part
@daveisfera
Copy link
Author

Looks great! Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment