Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple-clang support #43

Closed
ericLemanissier opened this issue Jan 13, 2022 · 6 comments
Closed

apple-clang support #43

ericLemanissier opened this issue Jan 13, 2022 · 6 comments
Labels
bug Something isn't working macos MacOS-specific issue

Comments

@ericLemanissier
Copy link

Hello, I'm currently trying to make a conan package for qcoro on conan-io/conan-center-index#8870,
but the build on apple-clang 12 fails with

/Users/jenkins/w/BuildSingleReference@3/.conan/data/qcoro/0.4.0/_/_/build/77eb698670f46be85ef6b72390c811f44c09c9aa/source_subfolder/qcoro/concepts_p.h:9:10: fatal error: 'concepts' file not found
#include <concepts>

More details on https://c3i.jfrog.io/c3i/misc/logs/pr/8870/5-configs/macos-clang/qcoro/0.4.0//77eb698670f46be85ef6b72390c811f44c09c9aa-build.txt

is apple-clang supported ? If yes, starting with which version ?

Thanks !

@ysc3839
Copy link
Contributor

ysc3839 commented Jan 13, 2022

According to https://en.cppreference.com/w/cpp/compiler_support/20, I think it's not supported.

@ericLemanissier
Copy link
Author

ok. These two commits lead me to think otherwise; 6629c7d b6787b7

@danvratil danvratil added bug Something isn't working macos MacOS-specific issue labels Jan 13, 2022
@danvratil
Copy link
Owner

Hmm, the MacOS support may have been added before I introduced the <concepts> header dependency and thus broken the build, since I'm not testing on MacOS regularily...I really have to add MacOS CI :-)

As far as I know, the concepts implementation in libc++ is rather incomplete, although on Linux at least I do have the header. I'll try to fix it, I'd like to have MacOS fully supported!

@ericLemanissier
Copy link
Author

loosely linked to this issue, but qcoro has been approved in conan-center : https://conan.io/center/qcoro

@danvratil
Copy link
Owner

Thanks a lot for submitting QCoro to Conan, much appreciated!

Sadly, I did not yet get around to undust my Macbook and get it working there again :(

@danvratil
Copy link
Owner

I was only able to test with apple-clang 13.0.0 (on Big Sur) and since commit b4abc58 the build works and tests pass.

It's possible that older versions of apple-clang won't work due to lack of C++20 support. But at least we now have MacOS CI, so it shouldn't break again :-)

Is it possible to specify minimum supported version of MacOS/XCode (not sure which one defines the version of apple-clang) on conan.io?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macos MacOS-specific issue
Projects
None yet
Development

No branches or pull requests

3 participants