qcoro 0.4.0 #8870
Merged
qcoro 0.4.0 #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ericLemanissier
force-pushed
the
qcoro
branch
from
21e0b4d
to
616b9dc
Compare
This comment has been minimized.
This comment has been minimized.
also, clean more cmake files
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
All green in build 7 (
|
prince-chrismc
approved these changes
Jan 15, 2022
SSE4
approved these changes
Jan 18, 2022
SpaceIm
reviewed
Feb 20, 2022
|
|
||
| def requirements(self): | ||
| self.requires("qt/6.2.2") | ||
| self.requires("expat/2.4.2", override=True) |
There was a problem hiding this comment.
Why expat version is overridden?
There was a problem hiding this comment.
I don't remember. probably a conflict in qt requirements ?
There was a problem hiding this comment.
Would be nice to remove it in the next PR.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: qcoro/0.4.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.