Fix and clarify exception handling in generators #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both sync and async generators now behave the same way. If the generator coroutine throws an exception, it is rethrown either from generator's begin() method, or when incrementing the generator iterator. Afterwards both the iterator and the generator are considered invalid and may not be used anymore.
danvratil
force-pushed
the
generator-exceptions
branch
from
c965f5f
to
4dc3bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both sync and async generators now behave the same way. If the
generator coroutine throws an exception, it is rethrown either
from generator's begin() method, or when incrementing the
generator iterator.
Afterwards both the iterator and the generator are considered
invalid and may not be used anymore.