Handle when a task is co_awaited by multiple awaiters #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old approach caused that the last awaiter to co_await a coroutine function has overwritten the reference to the previous (so that any previous awaiter would not be resumed when the coroutine function has finished) but at the same time the `await_suspend()` would return `false`, so that the awaiter would get resume again immediatelly. However, since the last awaiter has also been registered as the only awaiting coroutine, once the awaited coroutine has finished, the awaiter was resumed for the second time, even if not suspended, causing crashes or memory leaks. This change makes `TaskAwaiterBase::await_suspend()` a void function, and stores awaiters as a list, so that they can all get resumed when the coroutine finishes.
danvratil
force-pushed
the
bug/multiple-awaiters
branch
from
4251b64
to
0f3beba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old approach caused that the last awaiter to co_await a coroutine function has overwritten the reference to the previous (so that any previous awaiter would not be resumed when the coroutine function has finished) but at the same time the
await_suspend()would returnfalse, so that the awaiter would get resume again immediatelly. However, since the last awaiter has also been registered as the only awaiting coroutine, once the awaited coroutine has finished, the awaiter was resumed for the second time, even if not suspended, causing crashes or memory leaks.This change makes
TaskAwaiterBase::await_suspend()a void function, and stores awaiters as a list, so that they can all get resumed when the coroutine finishes.