Make QCoroTask header contain only declarations #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danvratil
force-pushed
the
feature/split-qcorotask-to-impl
branch
3 times, most recently
from
14ac1c7
to
7a52714
Compare
Definitions are moved into private files inside the impl/ subdirectory. This makes the header cleaner and easier to read and also solves repeated problem with the need for out-of-line definitions for some methods as they refer to other classes declared in the QCoroTask header. This is a fully source-compatible change.
danvratil
force-pushed
the
feature/split-qcorotask-to-impl
branch
from
7a52714
to
930696d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitions are moved into private files inside the impl/ subdirectory. This makes the header cleaner and easier to read and also solves repeated problem with the need for out-of-line definitions for some methods as they refer to other classes declared in the QCoroTask header.
This is a fully source-compatible change.