Permit Buffer and binary string as options.data. #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change Buffer was subjected to stringify as it matched the 'object' typeof test. binary string also ended up corrupt. This change ensures we're done with encoding by the time we write to the request.
|
node.js is pretty new to me so let me know if I've missed anything obvious or made a mess. Thanks. |
|
This fixes some of the issues I am having with posting files directly without wrapping it in a form first. |
|
Closing my PR. Last change in this project was > 4 years ago so not likely to be merged and now has conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change Buffer was subjected to stringify as it matched the
'object' typeof test. binary string also ended up corrupt. This change
ensures we're done with encoding by the time we write to the request
and adds some tests that previously failed.