Auto-detect annotation types

[meijieru]

vim-doge doesn't need to specify the type to annotate.
Could we have similar features?

[danymat]

Hello! thanks for chiming in !

vim-doge doesn't need to specify the type to annotate.
Could we have similar features?

In theory we could indeed, but we need to do it well if we're about to do it.
Just for you to know, atm, in order to generate the annotations we:

• call the annotator function with a specified type
• search the first upper node that matches the type
• Generate the annotations for the node

I think it is not a problem if we only have classes, and functions annotations (and templates too). What happens if we have the cursor on a type annotation ? Like this:

local function test()
  local test_var = do_smt() --> cursor on this line will generate a type annotation just before this line
  -- this is a comment  
end

[meijieru]

I think the behavior in the comment is decent.

[danymat]

Sorry for putting this feat on hold, as it was the holidays season. I'm thinking about it right now:

Do you know what's the logic behind vim-doge automatic selection ? Or better, what do you think will be the best:

• Going up in the tree until we stop on a first matching node, no matter what the type?
• Having a priority list of types, that we will loop until we stop on a matching node, i.e:

priority = { "func", "class", "type", ...}

[meijieru]

I am not familiar with the vim-doge's logic.
Personally, I prefer the second option.
Maybe some polls may help.

[danymat]

This will have the same complexity (mostly) as this issue (point 2): #53 (comment)

I will try to keep this open for a while, in case someone wants to comment

[danymat]

@meijieru I recommend following and testing #74

[danymat]

#116 Implemented this feature, see Neogen 2.11 !