Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotation type autodetection #116

Merged
merged 7 commits into from
Jan 3, 2023
Merged

Add annotation type autodetection #116

merged 7 commits into from
Jan 3, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Nov 14, 2022

ref: #74

@ssiyad ssiyad mentioned this pull request Nov 14, 2022
Closed
@barakmich @ssiyad
Add annotation type autodetection
2c454f7 
Creates a new generate() type, `any`, which contextually adds an
annotation by whichever matching type is first found in the tree around
the cursor.

So, if your cursor is in a function, it will annotate the function, if
in a class or struct definition, it'll annotate that, etc.

Co-authored-by: Sabu Siyad <hello@ssiyad.com>
Signed-off-by: Sabu Siyad <hello@ssiyad.com>
@danymat
Copy link
Owner

danymat commented Nov 14, 2022

Hello, I had a quick look at the PR and thank you for your proposition !
I will need to actually try it and make some tests before merging.

One small thing though, i prefer func to stay the default generating method. The any method can be configured + passed in :Neogen ... call. Users will not see any regression, and we can discuss a bit more if users want to make it default.

@ssiyad
Copy link
Contributor Author

ssiyad commented Nov 15, 2022

I'd prefer any as default because it makes every type available out of the box. It will be far better than having multiple keybindings for each type. It will also eliminate the need of using type= for most users. Backward compatibility is a valid point, but any as default makes more sense

@danymat
Copy link
Owner

danymat commented Nov 15, 2022

I agree, then the semver version will need to update the major, because of possible backwards compatibility. I'm adding this to the commit

@ssiyad
Copy link
Contributor Author

ssiyad commented Nov 17, 2022 •
edited
Loading

@danymat cool. is there anything else I can help with, related to this PR?

danymat
danymat requested changes Dec 28, 2022
View reviewed changes
Copy link
Owner

@danymat danymat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I reviewed the code responsible for autodetection.
Sorry for the delay, life has been complicated these last months.
Thank's a lot for your PR, ping me for anything !
Regards

doc/neogen.txt Show resolved Hide resolved
lua/neogen/generator.lua Show resolved Hide resolved
lua/neogen/generator.lua Outdated Show resolved Hide resolved
lua/neogen/generator.lua Outdated Show resolved Hide resolved
@ssiyad
fix(generator): replace "any" -> ANY_TYPE
62ce187 
Signed-off-by: Sabu Siyad <hello@ssiyad.com>
@danymat danymat mentioned this pull request Dec 30, 2022
Closed
@danymat danymat merged commit 9a2ada8 into danymat:main Jan 3, 2023
@danymat
Copy link
Owner

danymat commented Jan 3, 2023

Hello,
Thanks a lot for your modifications, I added some info about the new version and released it with tags. Thank your for bringing neogen to 2.11 🥳 ❤️

@danymat danymat mentioned this pull request Jan 3, 2023
Merged
@ssiyad
Copy link
Contributor Author

ssiyad commented Jan 3, 2023

The honour is all mine. Thank you!

@danymat danymat mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danymat danymat danymat requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssiyad @danymat @barakmich