Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-6605 control: validate auto-generated config file #4676

Merged
merged 9 commits into from Feb 19, 2021
Merged

DAOS-6605 control: validate auto-generated config file #4676

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
10590ff
DAOS-XXX control: validate auto-generated config file
tanabarr Feb 17, 2021
53b41a8
avoid nil dereference on host errors
tanabarr Feb 17, 2021
0fc96a7
Merge branch 'master' of github.com:daos-stack/daos into tanabarr/con…
tanabarr Feb 17, 2021
d6f6c93
report ndctl bug in admin guide and refuse if no hosts specified
tanabarr Feb 17, 2021
182a435
don't embed cfgCmd into configGenCmd
tanabarr Feb 17, 2021
5a80b7b
show where control config was actually read from
tanabarr Feb 18, 2021
1835ab0
export config path
tanabarr Feb 18, 2021
ff061cc
update control config when cmd host list overridden by cli args
tanabarr Feb 18, 2021
ab4329d
fix unit tests and update release notes
tanabarr Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/control/lib/control/auto.go
View file
Open in desktop
Expand Up @@ -89,12 +89,9 @@ func ConfigGenerate(ctx context.Context, req ConfigGenerateReq) (*ConfigGenerate
return nil, err
}

// TODO: change Validate() to take io.Writer
// if err := cfg.Validate(&req.buf); err != nil {
// return &ConfigGenerateResp{
// Err: errors.Wrap(err, "validation failed on auto generated config"),
// }, nil
// }
if err := cfg.Validate(req.Log); err != nil {
return nil, errors.Wrap(err, "validation failed on auto generated config")
}

return &ConfigGenerateResp{ConfigOut: cfg}, nil
}
Expand Down