add genericscheme callData raw data to the proposal details view #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkent600
changed the title
dkent600
changed the title
roienatan
suggested changes
Aug 12, 2020
| <div> | ||
| <strong>NFT Contract:</strong> <a href={linkToEtherScan(decodedCallData.values[1])} target="_blank" rel="noopener noreferrer">{decodedCallData.values[1]}</a> | ||
| </div> | ||
| <div> | ||
| <strong>TokenID:</strong> {decodedCallData.values[2]} | ||
| </div> | ||
| <div> | ||
| <strong>Raw call data:</strong> |
There was a problem hiding this comment.
Don't we prefer to eliminate the use of <strong> and define the layout using div and CSS?
There was a problem hiding this comment.
I just didn't feel like this time refactoring and testing the entire thing, so just copied the pattern that was there
There was a problem hiding this comment.
On the code like this that is coming in from outside contributors, we can hopefully get them to follow these standards before accepting their PRs.
| @@ -16,6 +17,14 @@ interface IProps { | |||
|
|
|||
| export default class ProposalSummaryCO2ken extends React.Component<IProps, null> { | |||
|
|
|||
| private rawCallData(proposalState: IGenericPluginProposalState) { | |||
| return <> | |||
| <p>Raw call data:</p> | |||
There was a problem hiding this comment.
Please use i18next here and in the rest of the places.
roienatan
approved these changes
Aug 13, 2020
orenyodfat
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2021 for 2.0.