Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using the "[id: string]: any" pattern to suppress type errors #217

Closed
jellegerbrandy opened this issue May 15, 2019 · 3 comments
Closed

Comments

@jellegerbrandy
Copy link
Contributor

but instead follow @dOrgJelli 's suggestion: "If the only reason it exists is to suppress the typescript compiler error on line #33, then there is another way. Adding "suppressImplicitAnyIndexErrors": true to your tsconfig.json will get rid of the error when you use the index operator on the object."

@jellegerbrandy
Copy link
Contributor Author

We did, but this makes implement #227 much more cumbersome, because we have to copy all the query options that graph-node provides into the search types...

@jellegerbrandy
Copy link
Contributor Author

Reverting this change, as we need the flexibility in alchemy and we do not want to be bothered by copuing explicitly ALL query options of the subgraph.

@jellegerbrandy
Copy link
Contributor Author

change was reverted in 0211045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant