Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BigNumber Query Options #227

Closed
dOrgJelli opened this issue May 26, 2019 · 3 comments
Closed

Support BigNumber Query Options #227

dOrgJelli opened this issue May 26, 2019 · 3 comments

Comments

@dOrgJelli
Copy link
Contributor

Support BigNumber query option types for EntityClass.search(...) methods. This would, for example, enable querying all members who have "greater than 400 reputation".

This can be done by creating a new type that wraps the number property and the corresponding suffix:

interface BigNumberQuery {
  propertyName: string
  propertyValue: number
  suffix: "gt" | "lt" | "gte" | "lte"
}

image

@jellegerbrandy
Copy link
Contributor

Looks like a good idea.
Afaics, to "supporting" all these options is simply a matter of allowing these values as keys in IXXXQueryOptions.

(I do not how you want to do the "BigNumberQuery" type)

@jellegerbrandy
Copy link
Contributor

(before #217 was resolved we were actually "supporting" all these query options)

@jellegerbrandy
Copy link
Contributor

I re-insted the [id: string]: any in the query types, so we can pass any argument, as a quick but flexible solution - seemed better then copying over all the types from the graph...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants